Skip to content

Data types #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2024
Merged

Data types #243

merged 6 commits into from
Apr 16, 2024

Conversation

jonnathan-ls
Copy link
Contributor

Data types

📝 Goal

Article update

☑ What was done?

  • Pending text translation

@javascript-translate-bot javascript-translate-bot requested a review from a team June 16, 2022 01:34
@javascript-translate-bot
Copy link

Error: the article already translated in the Progress Issue #1 ⁉️

@jonnathan-ls
Copy link
Contributor Author

Error: the article already translated in the Progress Issue #1 ⁉️
#243 (comment) javascript-translate-bot

There is still text that has not been translated.

@odsantos
Copy link
Contributor

odsantos commented Dec 9, 2022

Error: the article already translated in the Progress Issue #1 interrobang
#243 (comment) javascript-translate-bot

There is still text that has not been translated.

Hi,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

Trying to know your plan regarding to this lesson.

Thanks, Osvaldo.

renatocfrancisco
renatocfrancisco reviewed Jul 31, 2023
View reviewed changes
Copy link

@renatocfrancisco renatocfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 73, the english sentence still in the file.
Moreover, good job!

@jonnathan-ls
Copy link
Contributor Author

jonnathan-ls commented Aug 6, 2023 •
edited
Loading

Olá @renatocfrancisco,

Obrigado pela observação, não tinha percebido ❤️

Olá @odsantos,

Will you translate the missing parts, including solution and task?
It would be helpful to review that as lesson, the whole translated article as well as the rest.

O PR contempla toda tradução do artigo, com exceção da linha 73 como citado pelo Renato
Adicionei um novo commit com o ajuste.

Por desencargo, também atualizei com a master do repositório original.

Poderia adicionar sua revisão a este PR?

@jonnathan-ls jonnathan-ls mentioned this pull request Aug 6, 2023
Open
@odsantos
Copy link
Contributor

odsantos commented Aug 8, 2023

Hi @jonnathan-ls , sim. Logo que possivel. Obrigado.

@nazarepiedady
Copy link
Member

@peruibeloko, @jonnathan-ls, what is missing in this pull request?

@jonnathan-ls
Copy link
Contributor Author

... what is missing in this pull request?

The review by two maintainers is missing, I will not contribute with the review, as the PR is precisely my own, there is no point in reviewing it myself

@nazarepiedady Could you add your review?

nazarepiedady
nazarepiedady approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could improve it more ahead, but for now, it is good enough to be approved.

@nazarepiedady
Copy link
Member

@jonnathan-ls, now we need one more review. It should take some time because we are running under forces.

@nazarepiedady
Copy link
Member

@peruibeloko, are you available to review this pull request?

peruibeloko
peruibeloko suggested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@peruibeloko peruibeloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duas mudanças rápidas e está aprovado

1-js/02-first-steps/05-types/article.md Outdated

For most purposes that's quite enough, but sometimes we need really big numbers, e.g. for cryptography or microsecond-precision timestamps.
Para a maioria dos propósitos, isso é o suficiente, mas às vezes precisamos de números realmente grandes, por exemplo, para criptografia ou carimbos de data/hora com precisão de microssegundos.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is duplicated at line 75

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

1-js/02-first-steps/05-types/article.md Outdated
```

You can check [*MDN* BigInt compatibility table](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#Browser_compatibility) to know which versions of a browser are supported.
Você pode verificar a [tabela de compatibilidade do *MDN* BigInt](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt#browser_compatibility) para saber quais versões de um navegador são suportadas.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Você pode verificar a [tabela de compatibilidade do *MDN* sobre BigInt]

ou

Você pode verificar a [tabela de compatibilidade do BigInt na *MDN*]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nazarepiedady
Copy link
Member

nazarepiedady commented Apr 9, 2024 •
edited
Loading

@jonnathan-ls, could you consider the reviews did?

@jonnathan-ls
Copy link
Contributor Author

jonnathan-ls commented Apr 14, 2024 •
edited
Loading

... could you consider the reviews did?

/done @nazarepiedady

I applied the requests noted by @peruibeloko, see commit 4a7029e. And I also added pending content that I noticed when accessing the article from the official English repository bigint-type session, see commit 7cafcbb

@javascript-translate-bot javascript-translate-bot requested a review from a team April 14, 2024 17:39
nazarepiedady
nazarepiedady approved these changes Apr 14, 2024
View reviewed changes
Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good enough to be approved.

peruibeloko
peruibeloko approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@peruibeloko peruibeloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nazarepiedady nazarepiedady merged commit e9d2d8c into javascript-tutorial:master Apr 16, 2024
@javascript-translate-bot
Copy link

Error: the article already translated in the Progress Issue #1 ⁉️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatocfrancisco renatocfrancisco renatocfrancisco left review comments

@peruibeloko peruibeloko peruibeloko approved these changes

@nazarepiedady nazarepiedady nazarepiedady approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonnathan-ls @javascript-translate-bot @odsantos @nazarepiedady @peruibeloko @renatocfrancisco